-
Notifications
You must be signed in to change notification settings - Fork 149
move the client logic out of main pkg so it can be reused. #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
1a5fba8 to
7efcbc0
Compare
|
hey @SuperQ, can you take a look? |
|
Happy Birthday to the PR 🎂🥳 |
end-to-end-test.sh
Outdated
| done | ||
|
|
||
| ./pushprox-client --log.level=debug --proxy-url=http://localhost:8080 & | ||
| ./pushprox-client --log.level=debug --proxy-url=http://localhost:8080 --fqdn $(hostname) & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this change needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably failed my tests but now it pass so I reverted it
|
Seems mostly fine. A couple questions. |
Signed-off-by: SagiROosto <sagi.rosenthal@oosto.com>
Signed-off-by: SagiROosto <sagi.rosenthal@oosto.com>
Signed-off-by: SagiROosto <sagi.rosenthal@oosto.com>
Signed-off-by: SagiROosto <sagi.rosenthal@oosto.com>
|
@SuperQ yea you got a point I reverted these odd changes and now it simply work as expected |
Summary
This PR refactors the Prometheus Pushprox client to move its core logic outside the main package, enabling it to be reused as a library in other projects. The primary motivation behind this change is to allow projects to integrate the proxy client directly into existing components, reducing the resource footprint significantly compared to running it as a standalone Docker container or binary.
Motivation
The original implementation of the Pushprox client was designed to run as a dedicated Docker container or a binary. While this works well in many scenarios, it introduces unnecessary overhead for projects that already have a metrics or health component and simply need to integrate the proxy client.
In my use case—likely shared by many others, especially in resource-constrained environments such as IoT devices—this overhead is critical. Running the client as part of an existing component saves resources and simplifies deployment without sacrificing functionality.
Changes
Benefits
Impact