Dynamic logging levels #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the ability to hide the API calls/results in the log by changing the log level on method call. Not passing in a log_level when calling the method defaults the log level to whatever the upper script's log level is.
Owner
|
Please rebase this PR on the current master. |
sparkstr
changed the base branch from
pyup-update-requests-2.23.0-to-2.24.0
to
master
Author
|
Updated PR to point at master |
Owner
|
That's not how rebasing works @sparkstr ;) See the conflicts. |
Collaborator
|
When we finish with #64 I'll help to rebase this one if that's ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to allow a logging level to be passed when calling methods for the rundeck API to change the level on API calls. Not providing a log level when using the methods will default the log level to the level of the entire script. Any existing external implementations will not be impacted.
Currently there is a single method
run_job()that takes a parameterlog_leveland does nothing with it. With this pull request it implements any log level changes that are desired.