feat(docs): embed Youtube videos in the docs #3323
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
alexcambose
reviewed
Dec 22, 2025
Comment on lines
+1
to
+21
| @use "@pythnetwork/component-library/theme"; | ||
|
|
||
| .container { | ||
| position: relative; | ||
| width: 100%; | ||
| padding-bottom: 56.25%; /* 16:9 aspect ratio */ | ||
| margin: theme.spacing(6) 0; | ||
| border-radius: theme.border-radius("xl"); | ||
| overflow: hidden; | ||
| background-color: theme.color("background", "primary"); | ||
| box-shadow: 0 4px 24px rgb(0 0 0 / 12%); | ||
| } | ||
|
|
||
| .iframe { | ||
| position: absolute; | ||
| top: 0; | ||
| left: 0; | ||
| width: 100%; | ||
| height: 100%; | ||
| border: none; | ||
| } |
Contributor
There was a problem hiding this comment.
I don't think you need a container here, stying iframe should be enough. You can remove all the iframe styles here and just copy paste the ones from .container and use https://github.com/pyth-network/pyth-crosschain/pull/3323/changes#r2640249221 instead of a padding-bottom trick
Comment on lines
+5
to
+6
| width: 100%; | ||
| padding-bottom: 56.25%; /* 16:9 aspect ratio */ |
Contributor
There was a problem hiding this comment.
width: 100%;
aspect-ratio: 16 / 9;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Embed Youtube videos in the relevant doc pages allowing users to watch the video on the same page. If they wish, they can redirect to YT.
Rationale
How has this been tested?