docs: replace deprecated getPrice() with getPriceNoOlderThan() in EVM troubleshooting guide #3324
+7
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… troubleshooting guide Co-Authored-By: Nidhi Singh <nidhi2894@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
| - Update the prices by calling [`updatePriceFeeds()`](https://api-reference.pyth.network/price-feeds/evm/updatePriceFeeds) | ||
| by passing the latest updateData from [Hermes](https://hermes.pyth.network/docs/#/rest/latest_vaas). | ||
| - Another method to fetch the price is [`getPriceUnsafe()`](https://github.com/pyth-network/pyth-crosschain/blob/main/target_chains/ethereum/sdk/solidity/AbstractPyth.sol#L41) | ||
| - Another method to fetch the price is [`getPriceUnsafe()`](https://api-reference.pyth.network/price-feeds/evm/getPriceUnsafe) |
Contributor
There was a problem hiding this comment.
this should point to
| To resolve this issue: | ||
|
|
||
| - Update the prices by calling [`updatePriceFeeds()`]("https://github.com/pyth-network/pyth-crosschain/blob/main/target_chains/ethereum/sdk/solidity/AbstractPyth.sol#L88") | ||
| - Update the prices by calling [`updatePriceFeeds()`](https://api-reference.pyth.network/price-feeds/evm/updatePriceFeeds) |
Contributor
There was a problem hiding this comment.
this should refer to the code
Co-Authored-By: Nidhi Singh <nidhi2894@gmail.com>
…back Co-Authored-By: Nidhi Singh <nidhi2894@gmail.com>
|
|
||
| - Fetch the latest fee by calling [`getUpdateFee()`](https://github.com/pyth-network/pyth-crosschain/blob/main/target_chains/ethereum/sdk/solidity/IPyth.sol#L112) method and | ||
| provide the required fee to `msg.value` when calling [`updatePriceFeeds()`](https://github.com/pyth-network/pyth-crosschain/blob/main/target_chains/ethereum/sdk/solidity/IPyth.sol#L112) method. | ||
| - Fetch the latest fee by calling [`getUpdateFee()`](https://api-reference.pyth.network/price-feeds/evm/getUpdateFee) method and |
Contributor
There was a problem hiding this comment.
this should point to
| - Fetch the latest fee by calling [`getUpdateFee()`](https://github.com/pyth-network/pyth-crosschain/blob/main/target_chains/ethereum/sdk/solidity/IPyth.sol#L112) method and | ||
| provide the required fee to `msg.value` when calling [`updatePriceFeeds()`](https://github.com/pyth-network/pyth-crosschain/blob/main/target_chains/ethereum/sdk/solidity/IPyth.sol#L112) method. | ||
| - Fetch the latest fee by calling [`getUpdateFee()`](https://api-reference.pyth.network/price-feeds/evm/getUpdateFee) method and | ||
| provide the required fee to `msg.value` when calling [`updatePriceFeeds()`](https://api-reference.pyth.network/price-feeds/evm/updatePriceFeeds) method. |
Contributor
There was a problem hiding this comment.
this should point to
Contributor
Author
There was a problem hiding this comment.
Done! I've updated all method links to point to GitHub source code. The updatePriceFeeds() link now points to
Co-Authored-By: Nidhi Singh <nidhi2894@gmail.com>
| To resolve this issue: | ||
|
|
||
| - Update the prices by calling [`updatePriceFeeds()`](https://api-reference.pyth.network/price-feeds/evm/updatePriceFeeds) | ||
| - Update the prices by calling [`updatePriceFeeds()`](https://github.com/pyth-network/pyth-crosschain/blob/9825470036fc24de3d52b139087ea0cd4117624a/target_chains/ethereum/sdk/solidity/AbstractPyth.sol#L90) |
Contributor
Author
There was a problem hiding this comment.
Done! Reverted the updatePriceFeeds() link in the PriceFeedNotFound section back to the API reference URL.
…API reference per review feedback Co-Authored-By: Nidhi Singh <nidhi2894@gmail.com>
nidhi-singh02
approved these changes
Dec 22, 2025
alexcambose
reviewed
Dec 22, 2025
Comment on lines
16
to
38
| - Update the prices by calling [`updatePriceFeeds()`](https://github.com/pyth-network/pyth-crosschain/blob/9825470036fc24de3d52b139087ea0cd4117624a/target_chains/ethereum/sdk/solidity/AbstractPyth.sol#L90) | ||
| by passing the latest updateData from [Hermes](https://hermes.pyth.network/docs/#/rest/latest_vaas). | ||
| - Another method to fetch the price is [`getPriceUnsafe()`](https://github.com/pyth-network/pyth-crosschain/blob/main/target_chains/ethereum/sdk/solidity/AbstractPyth.sol#L41) | ||
| - Another method to fetch the price is [`getPriceUnsafe()`](https://github.com/pyth-network/pyth-crosschain/blob/9825470036fc24de3d52b139087ea0cd4117624a/target_chains/ethereum/sdk/solidity/AbstractPyth.sol#L43) | ||
| If the price feed is available, the method will return the latest prices with timestamp of last update. | ||
| NOTE: `getPriceUnsafe()` method does not check the freshness of the price. | ||
|
|
||
| #### getPrice() reverts with `PriceFeedNotFound()` or `0x14aebe68` error | ||
| #### getPriceNoOlderThan() reverts with `PriceFeedNotFound()` or `0x14aebe68` error | ||
|
|
||
| This error occurs when the requested price feed has not been updated on-chain, or the price feed id is incorrect. | ||
|
|
||
| To resolve this issue: | ||
|
|
||
| - Update the prices by calling [`updatePriceFeeds()`](https://api-reference.pyth.network/price-feeds/evm/updatePriceFeeds) | ||
| by passing the latest updateData from [Hermes](https://hermes.pyth.network/docs/#/rest/latest_vaas). | ||
| - Check the entered [price feed id](../price-feeds) and [pyth-contract address](https://docs.pyth.network/price-feeds/contract-addresses/evm) to make sure they are correct. | ||
|
|
||
| #### updatePriceFeeds() reverts with `InsufficientFee()` or `0x025dbdd4` error | ||
|
|
||
| This error occurs when the fee provided for updating the price feed is insufficient. | ||
| To resolve this issue: | ||
|
|
||
| - Fetch the latest fee by calling [`getUpdateFee()`](https://github.com/pyth-network/pyth-crosschain/blob/main/target_chains/ethereum/sdk/solidity/IPyth.sol#L112) method and | ||
| provide the required fee to `msg.value` when calling [`updatePriceFeeds()`](https://github.com/pyth-network/pyth-crosschain/blob/main/target_chains/ethereum/sdk/solidity/IPyth.sol#L112) method. | ||
| - Fetch the latest fee by calling [`getUpdateFee()`](https://github.com/pyth-network/pyth-crosschain/blob/9825470036fc24de3d52b139087ea0cd4117624a/target_chains/ethereum/sdk/solidity/IPyth.sol#L93) method and | ||
| provide the required fee to `msg.value` when calling [`updatePriceFeeds()`](https://github.com/pyth-network/pyth-crosschain/blob/9825470036fc24de3d52b139087ea0cd4117624a/target_chains/ethereum/sdk/solidity/AbstractPyth.sol#L90) method. |
Contributor
There was a problem hiding this comment.
this is not from /main anymore, is that intended?
Contributor
Author
There was a problem hiding this comment.
Yes, this is intentional. @nidhi-singh02 requested that the method links point to a specific commit (9825470036fc24de3d52b139087ea0cd4117624a) rather than /main to ensure the line numbers remain stable and don't break if the source file is modified in the future.
Contributor
There was a problem hiding this comment.
okay sir I didn't know you also respond lol
alexcambose
approved these changes
Dec 22, 2025
Contributor
alexcambose
left a comment
alexcambose
left a comment
There was a problem hiding this comment.
lgtm, seems the links have changed to 9825470036fc24de3d52b139087ea0cd4117624a commit though, idk if that's intended
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the EVM troubleshooting documentation to replace references to the deprecated
getPrice()method with the recommendedgetPriceNoOlderThan()method. Also updates method links to point to GitHub source code at a specific commit for stability.Rationale
The
getPrice()method is deprecated in the Pyth EVM SDK (as noted inAbstractPyth.sol). The recommended replacement isgetPriceNoOlderThan(), which provides more flexibility by allowing users to specify the maximum age of the price via theageparameter.Changes made:
getPrice()togetPriceNoOlderThan()ageparameter instead ofvalidTimePeriodgetValidTime()method9825470036fc24de3d52b139087ea0cd4117624a(except one link kept as API reference per review feedback)How has this been tested?
Documentation-only change. Verified the deprecated status of
getPrice()andgetValidTime()by reviewing the SDK source code intarget_chains/ethereum/sdk/solidity/AbstractPyth.sol.Human Review Checklist
updatePriceFeeds()→ AbstractPyth.sol#L90 (in StalePrice and InsufficientFee sections)getPriceUnsafe()→ AbstractPyth.sol#L43getUpdateFee()→ IPyth.sol#L93updatePriceFeeds()link in the PriceFeedNotFound section correctly uses the API reference URL (kept per review feedback)getPrice()methodLink to Devin run: https://app.devin.ai/sessions/87cef1e82e034658ad12642f6cf66e09
Requested by: Nidhi Singh (@nidhi-singh02)