Factor out import scanner #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't have swappable ImportScanners anyway, so this complicates the design.
This removes all mention of ImportScanner from Python.
seddonym
force-pushed
the
factor-out-import-scanner
branch
from
ad4b188 to
a3f6e0c
Compare
CodSpeed Instrumentation Performance ReportMerging #237 will not alter performanceComparing Summary
|
This was referenced Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors so that we no longer use an
ImportScannerclass - instead the Rust extension module exposes ascan_for_importsfunction that can scan multiple module files, rather than just one. In a future PR this will allow us to manage concurrency within Rust if need be.