Scanning optimization #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was inefficient to scan through all the found packages each time.
CodSpeed Instrumentation Performance ReportMerging #242 will improve performances by 27.65%Comparing Summary
Benchmarks breakdown
|
Peter554
reviewed
Aug 29, 2025
rust/Cargo.toml
Outdated
| serde_yaml = "0.9" | ||
| unindent = "0.2.4" | ||
| encoding_rs = "0.8.35" | ||
| once_cell = "1.21.3" |
Collaborator
There was a problem hiding this comment.
Do we need to add once_cell? Can we use lazy_static (already a project dependency) or even std::cell::OnceCell?
Collaborator
Author
There was a problem hiding this comment.
Good idea - I've switched to lazy_static for consistency.
Peter554
approved these changes
Aug 29, 2025
We were compiling this in each loop. On a large codebase, this contributed to ~10% of the time taken to build the graph.
seddonym
force-pushed
the
scanning-optimization
branch
from
a9d5381 to
b53a0ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a couple of optimizations for scanning very large code bases, based on running samply on a large closed-source code base. On my laptop it takes the time building the graph from around 4s to 3s.