Skip to content

Conversation

@LilyFirefly
Copy link
Contributor

No description provided.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 5, 2025

CodSpeed Instrumentation Performance Report

Merging #243 will improve performances by 15.89%

Comparing LilyAcorn:upgrade-pyo3 (94561f2) with main (fe24997)

Summary

⚡ 4 improvements
✅ 19 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_deep_layers_large_graph_kept 20 ms 17.3 ms +15.89%
test_deep_layers_large_graph_violated 11.9 ms 10.8 ms +10.36%
test_no_chain 1.2 ms 1.1 ms +12.05%
test_no_chains 1.2 ms 1.1 ms +12.06%

@LilyFirefly LilyFirefly force-pushed the upgrade-pyo3 branch 3 times, most recently from e7a03ad to af3eed1 Compare September 5, 2025 10:00
@LilyFirefly
Copy link
Contributor Author

I'm not sure why this has regressed performance. I tried downgrading indexmap, but that made no difference, so it's not clear to me what's changed.

@LilyFirefly
Copy link
Contributor Author

Hmm, I'm starting to think those benchmarks are just a bit flaky.

@seddonym seddonym merged commit ae655cb into python-grimp:main Sep 5, 2025
18 checks passed
@LilyFirefly LilyFirefly deleted the upgrade-pyo3 branch September 5, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants