Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the reading of the cache data file to Rust.
This doesn't make much difference to the performance as it stands, but in a follow up PR we will want to optimize this (probably by moving from JSON to a binary file format) and we might as well do it in Rust.
A large proportion of the time we spend building the graph from a cache is spent reading and deserializing the data cache file - nearly 0.8s of the 1.2s taken to scan this large graph.
The benchmarks indicate a regression, but it doesn't seem to make a significant difference running this locally on a large graph.
Before
After