Skip to content

Conversation

@2br-2b
Copy link
Contributor

@2br-2b 2br-2b commented Dec 14, 2024

Fixes #210

Changes proposed in this pull request:

  • Add support for en_GB and en_US

@codecov
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.48%. Comparing base (db482bb) to head (628a76b).
Report is 62 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #222   +/-   ##
=======================================
  Coverage   99.47%   99.48%           
=======================================
  Files          11       11           
  Lines         760      771   +11     
=======================================
+ Hits          756      767   +11     
  Misses          4        4           
Flag Coverage Δ
macos-latest 97.07% <100.00%> (+0.06%) ⬆️
ubuntu-latest 97.07% <100.00%> (+0.06%) ⬆️
windows-latest 95.42% <100.00%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hugovk hugovk added the changelog: Added For new features label Dec 14, 2024
@hugovk hugovk changed the title Add en_GB and en_US Handle en_GB and en_US in i18n Dec 14, 2024
@hugovk
Copy link
Member

hugovk commented Dec 14, 2024

Thanks for the PR, please could you check mypy and add a test?

@2br-2b
Copy link
Contributor Author

2br-2b commented Dec 14, 2024

Sure thing! I'll do that now real quick

@hugovk
Copy link
Member

hugovk commented Feb 4, 2025

See #230 for a followup.

@hugovk hugovk closed this in #230 Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: Added For new features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add en_GB and en_US

2 participants