Add a new dependency group called dev and add pip-tools to it.
#20207
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e some new stubs, I realized that the requirements.txt files tell you to run pip-compile --output-file=test-requirements.txt --strip-extras --allow-unsafe test-requirements.in, and thus have an implicit undeclared requirement on pip-tools. I tried adding this to build-requirements.txt but that broke some things so I put it in a new extra called dev instead.
This comment has been minimized.
This comment has been minimized.
cdce8p
reviewed
Nov 8, 2025
wyattscarpenter
changed the title
dev and add pip-tools to it.dev and add pip-tools to it.
This comment has been minimized.
This comment has been minimized.
wyattscarpenter
commented
Dec 10, 2025
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was adapting the mypy codebase to include some new stubs, I realized that the requirements.txt files tell you to run
pip-compile --output-file=test-requirements.txt --strip-extras --allow-unsafe test-requirements.in, and thus have an implicit undeclared requirement onpip-tools. I tried adding this to build-requirements.txt but that broke some things so I put it in a newextradependency group called dev instead.A specific version floor is required due to very broken behavior on an earlier version of pip-tools. As is the version ceiling on pip because, wouldn't you know it, a later version of pip broke compatibility with pip-tools again. (I discovered that by manual testing, and my manual testing tells me this change apparently works fine; I can install the extra and then run the command with
uv run(an isolated environment).)