Skip to content

Remove mypy and clean up type checker suppression comments #3475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rchen152 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove mypy and clean up type checker suppression comments #3475

rchen152 wants to merge 2 commits into from

Conversation

@rchen152
Copy link
Contributor

@rchen152 rchen152 commented Dec 10, 2025

Fixes #3473

This is a follow-up to #3474, which added the pyrefly type checker. This PR removes mypy and cleans up some ignore comments.

  • Removes mypy from CI, deletes mypy.ini, and switches documentation over to reference pyrefly.
  • Removes 19 # type: ignore comments that mypy used and pyrefly doesn't.
  • Refactors the code a bit and tweaks some type annotations, allowing us to remove 24 # pyrefly: ignore comments.

@github-actions github-actions bot added module: engine Engine module module: metrics Metrics module module: handlers Core Handlers module module: distributed Distributed module module: contrib Contrib module ci CI labels Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ci CI module: contrib Contrib module module: distributed Distributed module module: engine Engine module module: handlers Core Handlers module module: metrics Metrics module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pyrefly Type Checking?

1 participant

@rchen152