Skip to content

Optimize as_strided_copy fast path to support offset #9728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zantares wants to merge 1 commit into
base: master
Choose a base branch
from
+29 −5
Open

Optimize as_strided_copy fast path to support offset #9728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 29 additions & 5 deletions torch_xla/csrc/aten_xla_type.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,9 +938,7 @@ static at::Tensor as_strided_eliminate_one_dim_fast_path(
// we can shuffle element in `stride` and `size` and this can result in the
// transpose of dimensions, but we don't consider this case here.
auto tensor_dim = tensor.sizes();
if (storage_offset.has_value() && (*storage_offset != 0)) {
return at::Tensor();
}
bool has_offset = (storage_offset.has_value() && (*storage_offset != 0));
if (tensor_dim.size() != stride.size() &&
tensor_dim.size() != stride.size() + 1) {
return at::Tensor();
Expand Down Expand Up @@ -971,6 +969,10 @@ static at::Tensor as_strided_eliminate_one_dim_fast_path(
}

if (tensor_dim.size() == stride.size() + 1) {
// Don't support offset in this case.
if (has_offset) {
return at::Tensor();
}
for (long i = 0, j = 0; i < size.size(); i++, j++) {
if (i == skip_dim) {
j++;
Expand Down Expand Up @@ -1013,9 +1015,31 @@ static at::Tensor as_strided_eliminate_one_dim_fast_path(
// stride.
K = 1;
}

// Calculate start index in reduce_size_location dimension from storage_offset
int64_t start = 0;
if (has_offset) {
int64_t base_storage_offset = tensor.storage_offset();
int64_t relative_storage_offset = (*storage_offset) - base_storage_offset;
if (stride[reduce_size_location] > 0) {
start = relative_storage_offset / stride[reduce_size_location];
} else {
// Negative stride not supported
return at::Tensor();
}
// Check if start is out of range
if (start < 0 || start >= tensor_dim[reduce_size_location]) {
return at::Tensor();
}
}
int64_t end = start + size[reduce_size_location] * K;
// Check if end is out of range
if (end > tensor_dim[reduce_size_location]) {
return at::Tensor();
}
XLA_ASSIGN_OR_THROW(XLATensorPtr xla_tensor, bridge::GetXlaTensor(tensor));
return bridge::AtenFromXlaTensor(tensor_methods::slice(
xla_tensor, reduce_size_location, 0, size[reduce_size_location] * K, K));
return bridge::AtenFromXlaTensor(
tensor_methods::slice(xla_tensor, reduce_size_location, start, end, K));
}

at::Tensor XLANativeFunctions::as_strided_copy(
Expand Down