Skip to content

wip: feat: require HTTPS for all outgoing HTTP requests #2517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
brynary wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

wip: feat: require HTTPS for all outgoing HTTP requests #2517

brynary wants to merge 3 commits into from

Conversation

@brynary
Copy link
Member

@brynary brynary commented Nov 20, 2025

QLTY_INSECURE_ALLOW_HTTP can be set to true for development / testing needs to override this behavior

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025

No issue mentions found. Please mention an issue in the pull request description.

Use GitHub automation to close the issue when a PR is merged

@brynary brynary changed the title feat: require HTTPS for all outgoing HTTP requests wip: feat: require HTTPS for all outgoing HTTP requests Nov 20, 2025
brynary
brynary commented Nov 20, 2025
View reviewed changes
qlty-cli/tests/cmd/check/exported_config_files.in/results.txt
@@ -1 +0,0 @@
sample.sh:2:1: OVERRIDE valid line
Copy link
Member Author

@brynary brynary Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to look at why this was deleted

qlty-config/src/http.rs Outdated
{
return Ok(());
}
}
Copy link
Member Author

@brynary brynary Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to look at removing this exception for localhost / loopback hosts

@qltysh
Copy link
Contributor

qltysh bot commented Nov 20, 2025 •
edited
Loading

Diff Coverage for ubuntu-latest: The code coverage on the diff in this pull request is 60.0%.

Total Coverage for ubuntu-latest: This PR will decrease coverage by 0.01%.

File Coverage Changes
Path File Coverage Δ Indirect
qlty-config/src/library.rs -0.5 √
qlty-coverage/src/ci/github.rs -0.3 √
qlty-coverage/src/publish/upload.rs -4.3
🛟 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@qltysh
Copy link
Contributor

qltysh bot commented Nov 20, 2025 •
edited
Loading

Diff Coverage for macos-15: The code coverage on the diff in this pull request is 61.0%.

Total Coverage for macos-15: This PR will decrease coverage by 0.01%.

File Coverage Changes
Path File Coverage Δ Indirect
qlty-config/src/http.rs -7.8
qlty-config/src/library.rs -0.5 √
qlty-coverage/src/ci/github.rs -0.3 √
qlty-coverage/src/publish/upload.rs 0.1
🛟 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brynary