Ensure translation is loaded via getTranslation().

[stooit]

When $entity->isPublished() is used in Seed.php it is returning the default language published state, rather than the translated revision.

By passing in an entity loaded via getTranslation we get the true published status of the translated revision.

(This behaviour appears to have been introduced in a relatively recent version of Drupal core).

[kepol]

Assigning to myself for review, testing, and merging.

[kepol]

It makes more sense to me to put the logic in Seed::seedNode so that any code that calls it will get this change rather than us having to remember to do this any time we call Seed::seedNode. I'll update the code to reflect this.

For example, it's called here too:

  public function onNodeInsert(NodeInsertEvent $event) {
    $entity = $event->getEntity();
    $langcode = $event->getLangcode();

    Seed::seedNode($entity, $langcode);
  }

function _quant_entity_update_op(EntityInterface $entity) {

  $langcode = $entity->language()->getId();
  
  switch ($entity->getEntityTypeId()) {
    case 'node':
      Seed::seedNode($entity, $langcode);
      break;
    
    case 'taxonomy_term':
      Seed::seedTaxonomyTerm($entity, $langcode);
      break;
  }

}

[kepol]

This would also be an issue with taxonomy terms

I'm going to do some updates based on my comments

[kepol]

I made the change but need to test it

[kepol]

I've created a branch for 2.x (feat/lang-published-status-2x) and tested against Drupal 11 using cron and it worked as expected... if the translation was unpublished then it didn't send it over when it wasn't supposed to and did when it was

I still need to test the feat/lang-published-status branch against D10

[kepol]

I have tested this branch with D10 and the 2.x version on D11 and my testing notes are here:

https://www.drupal.org/project/quantcdn/issues/353482

There is one issue but it's unrelated to what is being fixed here so I'm marking this approved and will get it merged into 1.x and 2.x accordingly