-
Notifications
You must be signed in to change notification settings - Fork 0
Add Data Format Converter #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aknierim
wants to merge
34
commits into
main
Choose a base branch
from
converter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,000
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in pyvisgen With this we can skip doing simulations over and over to get the same data in different formats, thus saving us many hours.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
- Coverage 96.20% 95.67% -0.53%
==========================================
Files 32 25 -7
Lines 2002 1619 -383
==========================================
- Hits 1926 1549 -377
+ Misses 76 70 -6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a data converter class that allows conversion between data formats for
pyvisgen.With this we can skip doing simulations over and over to get the same data in different formats, thus saving us many hours (e.g. ~20 min of conversion vs ~25h of new simulations).
To-Do
Note: I don't plan to include FITS for now, until we have fixed our FITS writer. Once that is taken care of, we can add FITS conversion, too.
Note 2: Draft for now until I have added the items from the To-Do list.Merge after #134