Prevent login trigger when a new tab is opened #1066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Does this impact the Ligthhouse score? |
Member
Author
|
It should not have any impact on lighthouse scores as user being sessionstorage would already trigger the refresh on load |
Member
|
We need this on 4.x and 5.x right? |
Member
|
Please double check this one @indykoning 😇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens due to the oldEmail check added for login-as-customer.
When a customer opens a new tab oldEmail is null so it triggers the login functions again even though the customer is already logged in.
Localstorage should be fine now, since we trigger a refresh of it's data upon opening a new tab or re-opening your browser.