[2.x] Added external video support #1068
Conversation
…ez/core into feature/external-video-support-2.x
|
|
||
| Str::macro( | ||
| 'embedUrl', | ||
| function ($url) { |
There was a problem hiding this comment.
This function is taken from Statamic, since it is not installed by default we utilise this macro
There was a problem hiding this comment.
Be aware that the license within Statamic does not necessarily allow for direct copies of its code without direct consent: https://github.com/statamic/cms/blob/5.x/LICENSE.md
There was a problem hiding this comment.
Please double check with @jackmcdade 😇 and add some love notes if it's ok to copy-paste ❤️
There was a problem hiding this comment.
Go for it, it's nothing particularly proprietary – just a bunch of string manipulation. Merry Christmas! 🎄
There was a problem hiding this comment.
Awesome! Thanks Jack, Merry Christmas 🚀
|
See: #1135 with regards to failing tests |
|
Follow up: RAP-1737 |
This PR adds external video support (By default Magento only does Vimeo + Youtube) to Rapidez 2.x
Due to it being available for an old Rapidez version it's been made to be backwards compatible so the images variable remains.
Once this has been approved i will create a PR for 3.x and 4.x with these changes (ROZ-415)