Only load used attributes on product detail #1143
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royduin
reviewed
Jan 13, 2026
| $productModel = config('rapidez.models.product'); | ||
| $productModel::shouldBeStrict(! App::isProduction()); // Throw errors if relations are used but not eager loaded if not in production. | ||
|
|
||
| $frontAttributes = EavAttribute::getCachedCatalog()->where('is_visible_on_front', 1)->pluck('attribute_id'); |
Member
There was a problem hiding this comment.
is_visible_on_front / "Visible on Catalog Pages on Storefront" is used to show/hide attributes from the specs table right? Is that the right thing to use here?
| public function show(int $productId) | ||
| { | ||
| $productModel = config('rapidez.models.product'); | ||
| $productModel::shouldBeStrict(! App::isProduction()); // Throw errors if relations are used but not eager loaded if not in production. |
Member
There was a problem hiding this comment.
Is this working? I'd to change the throwMissingAttributeExceptionIfApplicable() as we're overwriting it to make this work:
protected function throwMissingAttributeExceptionIfApplicable($key)
{
if ($this->hasCustomAttribute($key)) {
return $this->getCustomAttribute($key);
}
return parent::throwMissingAttributeExceptionIfApplicable($key);
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
after: