-
Notifications
You must be signed in to change notification settings - Fork 28
Adjust GH action to use containers #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
- Coverage 99.79% 99.79% -0.01%
==========================================
Files 9 9
Lines 1451 1443 -8
==========================================
- Hits 1448 1440 -8
Misses 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates the GitHub Actions CI workflow from using the actions/setup-python action to using Docker containers with Python images. This approach runs the entire job inside a Python container rather than installing Python on the GitHub Actions runner.
Key changes:
- Replaced
actions/setup-python@v5with container-based Python images (python:{version}-trixie) - Updated Python version format from "3.10.x" to "3.10" to match Docker tag conventions
- Applied the container approach to both
testandpublish-releasejobs
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:20
- The snok/install-poetry action may not work correctly when running inside a container. This action is designed to run on the GitHub Actions runner host, not inside a Docker container. When using containers, it's typically better to install Poetry directly using pip in a separate step, like:
- name: Install Poetry
run: python -m pip install -U pip poetry
This approach is already being used in the publish-release job (line 56) and would be more consistent across both jobs.
- name: Install Poetry
uses: snok/install-poetry@v1
with:
virtualenvs-in-project: true
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c01d370 to
61bd1ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
61bd1ce to
652391e
Compare
.github/workflows/ci.yml
Outdated
| matrix: | ||
| python-version: ["3.10.x", "3.11.x", "3.12.x", "3.13.x"] | ||
| runs-on: ubuntu-latest | ||
| python-version: ["3.10", "3.11", "3.12", "3.13"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.12, 3.13 and 3.14
.github/workflows/ci.yml
Outdated
| name: Test | ||
| runs-on: ubuntu-latest | ||
| container: | ||
| image: python:${{ matrix.python-version }}-bookworm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure there's a big argument for making all projects test like this.. it's more useful in the case of RP components which we use as containers elsewhere
652391e to
375dfdb
Compare
No description provided.