Skip to content

Conversation

@norkans7
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.79%. Comparing base (dd4195e) to head (375dfdb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   99.79%   99.79%   -0.01%     
==========================================
  Files           9        9              
  Lines        1451     1443       -8     
==========================================
- Hits         1448     1440       -8     
  Misses          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@norkans7 norkans7 marked this pull request as ready for review December 16, 2025 10:10
Copilot AI review requested due to automatic review settings December 16, 2025 10:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the GitHub Actions CI workflow from using the actions/setup-python action to using Docker containers with Python images. This approach runs the entire job inside a Python container rather than installing Python on the GitHub Actions runner.

Key changes:

  • Replaced actions/setup-python@v5 with container-based Python images (python:{version}-trixie)
  • Updated Python version format from "3.10.x" to "3.10" to match Docker tag conventions
  • Applied the container approach to both test and publish-release jobs
Comments suppressed due to low confidence (1)

.github/workflows/ci.yml:20

  • The snok/install-poetry action may not work correctly when running inside a container. This action is designed to run on the GitHub Actions runner host, not inside a Docker container. When using containers, it's typically better to install Poetry directly using pip in a separate step, like:
- name: Install Poetry
  run: python -m pip install -U pip poetry

This approach is already being used in the publish-release job (line 56) and would be more consistent across both jobs.

      - name: Install Poetry
        uses: snok/install-poetry@v1
        with:
          virtualenvs-in-project: true

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

matrix:
python-version: ["3.10.x", "3.11.x", "3.12.x", "3.13.x"]
runs-on: ubuntu-latest
python-version: ["3.10", "3.11", "3.12", "3.13"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.12, 3.13 and 3.14

name: Test
runs-on: ubuntu-latest
container:
image: python:${{ matrix.python-version }}-bookworm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure there's a big argument for making all projects test like this.. it's more useful in the case of RP components which we use as containers elsewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants