Update to properly support Symfony 6 (PHP 8+) #1095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Let's get this shipped, so we can focus on current Symfony 7 support in a follow-up |
This was referenced May 16, 2025
Closed
This was referenced May 30, 2025
This was referenced May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds proper support for Symfony 6 on PHP 8+. This is part 6 of reviving Ratchet as discussed in #1054, unblocking more future progress.
With these changes applied, the existing test suite recently updated with #1094, #1093 and #1092 now confirms that Symfony 6 can successfully be used on PHP 8+. Symfony 6 support was originally merged in #926 a while ago without proper tests. As a result, the optional session component reported fatal errors when used with Symfony 6 on PHP 8+ as reported in #969 and others. Once merged, I'll use this as a starting point to add newer Symfony 7 version support as discussed in #1045 and elsewhere.
Note that the implementation involves two new classes used for Symfony 6 compatibility only as originally suggested by @josh-gaby in #1014. This PR doesn't directly apply from the other PR mainly due to its broader scope and complexity, but it applies some very similar ideas. While this duplication isn't exactly perfect, I think it's good enough to get this working again. Future PRs to avoid this duplication welcome.
Overall, this still requires a massive effort. If you want to support this project, please consider sponsoring @reactphp ❤️
Builds on top of #1094, #1093, #1092, #1091 and #1088, one step closer to reviving Ratchet as discussed in #1054
Resolves / closes #969 and #963