Support PHP 8.3 and work around unserialize warnings #1097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Let's get this in so we can finally add current PHP 8.4+ support in a follow-up! |
🎉
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds support for PHP 8.3 and works around reporting any unserialize warnings for trailing data. This is part 8 of reviving Ratchet as discussed in #1054, unblocking more future progress.
With these changes applied, the existing test suite recently updated with #1096, #1094, #1093 and #1092 now works fine on PHP 8.3 at last. In particular, this works around warnings reported due to https://wiki.php.net/rfc/unserialize_warn_on_trailing_data (not to be confused with https://wiki.php.net/rfc/improve_unserialize_error_handling) as reported in #1076 and others. Once merged, I'll use this as a starting point to add newer PHP 8.4+ version support as discussed in #1003 and elsewhere.
Overall, this still requires a massive effort. If you want to support this project, please consider sponsoring @reactphp ❤️
Builds on top of #1096, #1094, #1093, #1092, #1091 and #1088, one step closer to reviving Ratchet as discussed in #1054
Resolves / closes #1076