Updated to use Distro package for Python 3.8 compatibility #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platform.linux_distribution was removed in Python 3.8 and Distro is the recommended replacement
Author
|
Builds are failing because Python 3.2 and 3.3 packages are missing and PyYAML requires Python 3.5+ (https://pyyaml.org/wiki/PyYAML) |
|
This is virtually the same pull request as #7. |
|
i am creating new module with syncronous asyncronous and cli named PyIpify |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
platform.linux_distribution was removed in Python 3.8 and Distro is the recommended replacement.
I'm still pretty new to this so I can't figure out why when I run
python setup.py testI get this error:If I run the tests manually with
py.test --cov-report term-missing --cov ipify, it gets 100% coverage but test_ipify.py reports 71%.