replace linux_distribution function #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Without this fix, this package doesn't work on python 3.8. Would it be possible to get one of these PRs merged in and a new release any time soon? @rdegges Thanks! |
|
Just stumbled upon this - interesting that this is still open :) |
Author
This repo is no longer maintened per comment on other pull request #11 (comment). |
|
i am creating new module with syncronous asyncronous and cli named PyIpify |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linux_distribution() has been removed from the platform library. This pull request uses platform.release() for the user agent string for linux clients.
#7 is also a viable alternative, but requiring a 3rd party package seems overkill just to generate a user agent string but using the release() will not be consistent with historical data, @rdegges decision if that is significant.