Skip to content
This repository was archived by the owner on Oct 3, 2019. It is now read-only.

Conversation

@sbose78
Copy link
Member

@sbose78 sbose78 commented May 10, 2019

In this pull request,

  • a Deployment is created in the openshift-operators namespace such that
  • the corresponding service would be reachable by devconsole-app.openshift-operators.svc:8080

Calls to this service would be proxied from the console backend [1] .

  • Verify that console backend is able to proxy to this
  • Create Service
  • Watch and reconcile
  • Add tests
  • Parameterize the image name that is being deployed

https://github.com/openshift/console/blob/master/server/server.go#L34

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sbose78

If they are not already assigned, you can assign the PR to them by writing /assign @sbose78 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Labels: labels,
// Annotations: annotations,
},
Spec: v1.DeploymentConfigSpec{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not Deployment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. We could probably make it a Deployment since this is not going to use ImageStreams

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants