-
Notifications
You must be signed in to change notification settings - Fork 117
[feat] Remove support for Python < 3.9 and support for the legacy environment modules version 3 #3596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3596 +/- ##
===========================================
+ Coverage 91.19% 91.38% +0.19%
===========================================
Files 62 62
Lines 13622 13484 -138
===========================================
- Hits 12423 12323 -100
+ Misses 1199 1161 -38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1e009e3 to
e7041f7
Compare
|
I think there is something wrong with pytest-cov as it doesn't show as covered the imports and the function definitions 👀 |
5a16715 to
512e23c
Compare
512e23c to
b8c7eac
Compare
ekouts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR removes support for all Python versions lower than 3.9 and it also removes support of the legacy environment modules. The following changes are introduced in detail
TmodImplandTmod4Impltmod4name is deprecated in favor ofenvmodwhich corresponds to the modern environment modules.binutilswhich would cause the increased build times not suitable for CI. The howto examples are updated accordingly.osext.copytreeis deprecated as it is no more necessary.Closes #3583.
Closes #3269.