Skip to content

Conversation

@negillett
Copy link
Member

Previously these paramters used for urllib3's Retry were unset. Backoff max defaulted to 120, which was too low for Akamai's strict rate limiting. Jitter was also added to better spread requests, improve system stability.

@negillett negillett self-assigned this Jul 10, 2025
@negillett negillett requested a review from crungehottman July 10, 2025 17:30
@negillett
Copy link
Member Author

@crungehottman, unclear who else to add for review. Are you the owner of this now?
Also, codecov is unable to upload (rate limited). Locally, coverage report is 100%.
Also, I wasted a lot of time trying to create a test for settings but found it impractical, if not impossible, to mock the values with the way things are set up. In one existing test monkeypatch is used to try and override backoff but a quick check reveals that it's not. Maybe that's why no test of this nature was originally written by Rohan (which is abnormal for him, I'd say).

@crungehottman
Copy link
Member

@crungehottman, unclear who else to add for review. Are you the owner of this now?

Yes, I am the owner now (despite having zero prior contributions to this project 🙃). To my knowledge, this repo is only used by exodus, so requesting review from me should suffice for now.

Also, codecov is unable to upload (rate limited). Locally, coverage report is 100%.

I think #36 might fix the codecov issue.

Also, I wasted a lot of time trying to create a test for settings but found it impractical, if not impossible, to mock the values with the way things are set up. In one existing test monkeypatch is used to try and override backoff but a quick check reveals that it's not. Maybe that's why no test of this nature was originally written by Rohan (which is abnormal for him, I'd say).

That's fine! I appreciate the attempt and explanation. 🙂

Previously these paramters used for urllib3's Retry were unset. Backoff
max defaulted to 120, which was too low for Akamai's strict rate
limiting. Jitter was also added to better spread requests, improve
system stability.
@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3460dd7) to head (0fd6b22).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #35   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          150       152    +2     
=========================================
+ Hits           150       152    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@negillett
Copy link
Member Author

@crungehottman, looks like your patch worked!

@crungehottman crungehottman merged commit 547607e into release-engineering:master Jul 22, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants