Tests should include self-closing tags #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@pdl thanks! Is this an issue with newer Xcode versions? |
Author
|
Did you mean something else? Xcode appears to be an IDE for Apple products. In case you mean node, the results look the same on 8, 10, and 12. |
Owner
|
@pdl sorry, I was in a hurry and by mistake I thought this was an issue in another project of mine (https://github.com/remuslazar/osx-xliff-tool) - also having "xl"-something in the name.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xmlsplit appears not to handle self-closing tags: it appears to think it has seen only the open-tag and never finds the balanced close-tag. This PR demonstrates the problem, causing the test suite to fail, but I have not written a fix.