-
Notifications
You must be signed in to change notification settings - Fork 133
Add types for many variables (for tests) #10632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
E2E Tests
|
| "test:ui": "playwright test --ui", | ||
| "test:install": "playwright install", | ||
| "ts-node": "ts-node --project ../../tsconfig.json" | ||
| "ts-node": "ts-node --project tsconfig.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this looks intuitively correct, it also feels like there might be a lot more work falling out of this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure where we actually use this command at this point, if at all
Domiii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange that there were so many types missing. These tests come from before the AI era 🤷
No description provided.