Skip to content

Conversation

@Erotemic
Copy link

@Erotemic Erotemic commented Nov 26, 2023

This contains a minor cleanup for the Python code.

I removed unused imports (Added # NOQA to make linters happy about unused colorama imports, although maybe they can be removed? In any case I do recommend using the more modern rich library if you want pretty colors).

There were f-strings that didn't have any placeholders, so I removed the "f".

There were a few lines that ended with a semicolon, and those are removed.

There were a few inconsistencies in keyword argument assignments. I removed the spaces around the = in those cases to make them consistent.

I also have a question: Is Python 2.7 or Python 3.5- support necessary? The asyncio.coroutine stuff is deprecated, and that should be changed to async def instead. But if older Python support is required, then that stuff shouldn't change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant