Skip to content

chore: nits #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reecepbcups merged 1 commit into from
Apr 1, 2025
Merged

chore: nits #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions simapp/app/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ var (
BaseDenomUnit int64 = 18 // spawntag:evm

BaseDenom = "mydenom"
DisplayDenom = "MY_DENOM_DISPLAY" // TODO: ?
DisplayDenom = "MY_DENOM_DISPLAY"

// Bech32PrefixAccAddr defines the Bech32 prefix of an account's address
Bech32PrefixAccAddr = Bech32Prefix
Expand Down Expand Up @@ -363,7 +363,6 @@ func NewChainApp(
baseAppOptions ...func(*baseapp.BaseApp),
) *ChainApp {

// TODO: verify
// interfaceRegistry := GetInterfaceRegistry() // ?spawntag:evm
// appCodec := codec.NewProtoCodec(interfaceRegistry) // ?spawntag:evm
// legacyAmino := codec.NewLegacyAmino() // ?spawntag:evm
Expand Down
1 change: 0 additions & 1 deletion spawn/cfg.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,6 @@ func (cfg *NewChainConfig) SetupInterchainTest() error {
})
}

// TODO: allow selecting for other chains to generate from (ethos, saga)
// SetupLocalInterchainJSON sets up the local-interchain testnets configuration files.
func (cfg *NewChainConfig) SetupLocalInterchainJSON() {

Expand Down
2 changes: 0 additions & 2 deletions spawn/remove_features.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,6 @@ func (fc *FileContent) RemoveEVM() {

fc.HandleAllTagged(text)

// TODO: ante/ ?
fc.DeleteFile(path.Join("app", "config.go"))
fc.DeleteFile(path.Join("app", "token_pair.go"))
fc.DeleteFile(path.Join("app", "precompiles.go"))
Expand Down Expand Up @@ -351,7 +350,6 @@ func (fc *FileContent) RemoveMint() {
text := "mint"
fc.HandleAllTagged(text)

// TODO: Fix this so it does not break
fc.RemoveModuleFromText("MintKeeper", appGo)
fc.RemoveModuleFromText("mintkeeper", appGo)
fc.RemoveLineWithAnyMatch("minttypes.")
Expand Down
Loading