Remove deprecated GAE auth and replace with Google IAP #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old runtimes are no longer supported, and App Engine does not permit creating or updating go1 projects. This change introduces support of the go111 runtime. Newer runtimes no longer support login: handlers.
The old runtimes are no longer supported, and App Engine does not permit creating or updating go1 projects. This change introduces support of the go111 runtime. Newer runtimes no longer support login: handlers.
This updates the tiddly to use Google IAP instead of the simpler, and sadly deprecated, app.yaml access control. Tested and deployed on memex.ifup.org. Try to break in! :)
Add a service to backup the tiddly datastore to git on a cron job. This is useful for generating static sites and as an offsite backup.
- fix tiddler removal by RemoveGlob before deleting dir - fix tags by joining tags by spaces as per spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #4 and migrates the application to Google Cloud's Identity Aware Proxy (IAP).
I have an instance of this code running successfully at https://memex.ifup.org.
If this general approach looks OK I am happy to add a simple AUTHZ system that takes a ACL via an environment variable to allow for read-only access from anonymous users.
This still doesn't get us to upgrading to go113 because of some other issue with the appengine package though.