Skip to content

Additional safeguards for re-renders and error types #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dylanjustice wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Additional safeguards for re-renders and error types #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 19 additions & 12 deletions src/hooks/use-page-errors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,33 @@
import { useState, useCallback } from "react";
import { ResultRecord } from "andculturecode-javascript-core";
import { CollectionUtils, ResultRecord } from "andculturecode-javascript-core";

/**
* Hook to bundle common page error handling functionality
*/
export function usePageErrors() {
const [pageErrors, setPageErrors] = useState<Array<string>>([]);

const handlePageLoadError = useCallback(
(result: string | ResultRecord<any>) => {
if (typeof result === "string") {
setPageErrors((e) => [...e, result]);
return;
}
const handlePageLoadError = useCallback((result: any) => {
if (result instanceof ResultRecord) {
setPageErrors((errors: string[]) => [
...errors,
...result.listErrorMessages(),
]);
return;
}

setPageErrors((e) => [...e, ...result.listErrorMessages()]);
},
[]
);
if (typeof result === "string") {
setPageErrors((errors: string[]) => [...errors, result]);
return;
}

setPageErrors((errors: string[]) => [...errors, result.toString()]);
}, []);

const resetPageErrors = useCallback(() => {
setPageErrors([]);
setPageErrors((prevState) =>
CollectionUtils.hasValues(prevState) ? [] : prevState
);
}, []);

return {
Expand Down