Skip to content

Conversation

@myty
Copy link
Collaborator

@myty myty commented Aug 3, 2025

Update .gitignore and Dockerfile, modify devcontainer settings, and enhance README with new .NET version options

Copilot AI review requested due to automatic review settings August 3, 2025 16:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the .NET, Node.js, and MS SQL Devcontainer template to use newer versions and improve configuration. The main purpose is to modernize the development environment with updated .NET and Node.js versions while removing outdated options.

  • Updates .NET version proposals to include 9.0 and 10.0-preview while removing 6.0 and 7.0 versions
  • Changes the default .NET version from 8.0-bookworm to 9.0-bookworm
  • Updates Node.js version options and adds TypeScript to keywords

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
devcontainer-template.json Updates .NET and Node.js version proposals, changes defaults, adds TypeScript keyword
README.md Updates documentation to reflect new default .NET version
devcontainer.json Simplifies postCreateCommand script invocation
Dockerfile Simplifies SQL tools installation script invocation and improves formatting
Comments suppressed due to low confidence (3)

src/dotnet-node-mssql/devcontainer-template.json:14

  • The .NET 10.0-preview version may not exist yet. .NET follows a yearly release cycle, and as of January 2025, .NET 9.0 was the latest version. Consider verifying if .NET 10.0-preview is actually available.
				"10.0-preview",

src/dotnet-node-mssql/devcontainer-template.json:17

  • The .NET 10.0-preview-trixie version may not exist yet. This appears to be combining a potentially non-existent .NET version with a Debian codename that may not be current for .NET containers.
				"10.0-preview-trixie",

src/dotnet-node-mssql/devcontainer-template.json:20

  • The .NET 10.0-preview-noble version may not exist yet. This appears to be combining a potentially non-existent .NET version with an Ubuntu codename.
				"10.0-preview-noble",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant