Skip to content

Fix test_rendering flaky pager test #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tompng wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −4
Open

Fix test_rendering flaky pager test #1152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions test/irb/yamatanooroti/test_rendering.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,9 +399,8 @@ def test_pager_page_content_doesnt_page_output_when_it_fits_in_the_screen
LINES
start_terminal(10, 80, %W{ruby -I#{@pwd}/lib #{@pwd}/exe/irb}, startup_message: /irb\(main\)/)
write("IRB::Pager.page_content('a' * (80 * 7))\n")
write("'foo' + 'bar'\n") # eval something to make sure IRB resumes

assert_screen(/a{80}/)
write("'foo' + 'bar'\n") # eval something to make sure IRB resumes
# because pager is not invoked, foobar will be evaluated
assert_screen(/foobar/)
close
Expand All @@ -413,9 +412,11 @@ def test_long_evaluation_output_is_paged
LINES
start_terminal(10, 80, %W{ruby -I#{@pwd}/lib #{@pwd}/exe/irb}, startup_message: /irb\(main\)/)
write("'a' * 80 * 11\n")
write("'foo' + 'bar'\n") # eval something to make sure IRB resumes

assert_screen(/"a{79}\n(a{80}\n){7}/)

write("'foo' + 'bar'\n")
write("q\n") # quit pager
assert_screen(/irb\(main\):002>/) # make sure IRB resumes
# because pager is invoked, foobar will not be evaluated
assert_screen(/\A(?!foobar)/)
close
Expand Down Expand Up @@ -443,6 +444,7 @@ def test_long_evaluation_output_is_preserved_after_paging
LINES
start_terminal(10, 80, %W{ruby -I#{@pwd}/lib #{@pwd}/exe/irb}, startup_message: /irb\(main\)/)
write("'a' * 80 * 11\n")
assert_screen(/(a{80}\n){6}/) # wait for pager to show up
write("q") # quit pager
write("'foo' + 'bar'\n") # eval something to make sure IRB resumes

Expand Down