Skip to content

🐛 Fix config.responses_without_block = :frozen_dup (backport to 0.5) #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nevans merged 1 commit into from
Dec 17, 2025
+6 −2
Merged

🐛 Fix config.responses_without_block = :frozen_dup (backport to 0.5) #588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/net/imap.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3233,7 +3233,7 @@ def responses(type = nil)
warn(RESPONSES_DEPRECATION_MSG, uplevel: 1, category: :deprecated)
when :frozen_dup
synchronize {
responses = @responses.transform_values(&:freeze)
responses = @responses.transform_values { _1.dup.freeze }
responses.default_proc = nil
responses.default = [].freeze
return responses.freeze
Expand Down
6 changes: 5 additions & 1 deletion test/net/imap/test_imap_responses.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,13 +151,17 @@ def assert_responses_warn
assert_equal [], imap.responses["FAKE"]
end
assert_empty stderr
# opt-in to future behavior
# default behavior since 0.6.0
imap.config.responses_without_block = :frozen_dup
stderr = EnvUtil.verbose_warning do
assert imap.responses.frozen?
assert imap.responses["CAPABILITY"].frozen?
assert_equal(%w[IMAP4REV1 NAMESPACE MOVE IDLE UTF8=ACCEPT],
imap.responses["CAPABILITY"].last)
imap.responses do |r|
refute r.frozen?
refute r.values.any?(&:frozen?)
end
end
assert_empty stderr
end
Expand Down