Bug-5152 Updates storage_location export to pull in all org items, no… #5210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsbonus
commented
May 29, 2025
| def self.generate_csv_from_inventory(storage_locations, inventory) | ||
| all_items = inventory.all_items.uniq(&:item_id).sort_by(&:name) | ||
| additional_headers = all_items.map(&:name).uniq | ||
| def self.generate_csv_from_inventory(storage_locations, inventory, current_organization) |
Contributor
Author
There was a problem hiding this comment.
This could get moved to just being an options hash, which is my general preference vs array of args. Thoughts?
Collaborator
There was a problem hiding this comment.
You can use keyword arguments instead of an option hash.
Collaborator
|
FWIW, what we have now passes my functional testing. |
dorner
requested changes
May 30, 2025
Collaborator
dorner
left a comment
dorner
left a comment
There was a problem hiding this comment.
Previous comments re hardcoded CSVs apply here as well.
| # Yes it's another full table scan, but it's a small dataset and product wants the exports to consistently include all items (active, inactive, etc). | ||
| # This means we have to look for inactive items or items without inventory. | ||
| # note the remapping of item.id to item_id is to enable the uniq call to happen once across the two arrays. | ||
| all_organization_items = current_organization.items.select("DISTINCT ON (LOWER(name)) items.name, items.id as item_id").order("LOWER(name) ASC") |
Collaborator
There was a problem hiding this comment.
This seems like a feature that should be built into the View::Inventory class. It's come up a few times. We should be able to specify "include non inventory items" in the all_items method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t just ones with inventory
Resolves #5202 partially
Description
Updates the Storage Location export to include all products, not just inventoried ones. This means brining in inactive products, not just ones with 0 inv.
Type of change
Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
Screenshots
storage_location_after_fix.csv
storage_location_before_fix.csv