Users should only be able to edit their own facilities. #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non Admin users do not see a link to edit their own facilities. The /edit path still works, making this security merely cosmetic since any user can access the edit page for any facility. We have a facility_users link table we can use to filter access. Perhaps the table needs to be updated to include a facility role as well. Roles could be 'admin', 'owner', 'staff'. We can use these roles to enable/disable certain behaviors per facilities in the future. Even without the extra role, we can still use the table to keep non facility users out of all but the "show" action. This change implements the access filter for facilities. Access is restricted for anything other than the "show" action for non facility user. If we think this is a reasonable approach, I can keep going down this path and improve this to include the roles as well.
app/models/user.rb
Outdated
| end | ||
|
|
||
| def is_site_admin? | ||
| site_admin? |
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non Admin users do not see a link to edit their own facilities. The /edit path still works, making this security merely cosmetic since any user can access the edit page for any facility.
We have a facility_users link table we can use to filter access. Perhaps the table needs to be updated to include a facility role as well. Roles could be 'admin', 'owner', 'staff'. We can use these roles to enable/disable certain behaviors per facilities in the future.
Even without the extra role, we can still use the table to keep non facility users out of all but the "show" action.
This change implements the access filter for facilities. Access is restricted for anything other than the "show" action for non facility user.
If we think this is a reasonable approach, I can keep going down this path and improve this to include the roles as well.