Add idle workflow tracking via internal event #261
+377
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3fd5bae The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Pull Request Test Coverage Report for Build 20801256245Details
💛 - Coveralls |
| commands.extend(subcommands) | ||
|
|
||
| # Check for idle transition at end of processing | ||
| was_idle = _check_idle_state(init) |
Collaborator
There was a problem hiding this comment.
does init ever change? We are checking this on every tick
Contributor
Author
There was a problem hiding this comment.
Yeah, that's the initial state of the reducer function call, so its effectively the "last" state
logan-markewich
approved these changes
Jan 6, 2026
Collaborator
logan-markewich
left a comment
logan-markewich
left a comment
There was a problem hiding this comment.
This makes sense to me
Add design document outlining the approach for tracking when workflows are idle (waiting on external input) in the workflow-server. Covers detection mechanisms, state tracking, and API changes needed to support releasing idle workflows.
Refocus design on event-based approach that: - Emits WorkflowIdleEvent/WorkflowResumedEvent on transitions - Keeps events lightweight with no metadata - Avoids depending on serialized context structure - Works with different workflow backends (DBOS, Temporal, etc.)
- Only WorkflowIdleEvent needed (resumption uses existing StepStateChanged) - Idle state computed from existing BrokerState fields, not stored - No changes to context serialization required
adrianlyjak
force-pushed
the
claude/idle-workflow-tracking-AHJQO
branch
from
7081baf to
3fd5bae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add idle workflow tracking
Implements tracking for when workflows become idle (waiting on external input via
ctx.wait_for_event()).Changes
WorkflowIdleEvent: Emitted when a workflow transitions to idle state_check_idle_state()helper to determine if all steps have no pending work but have active waiters_WorkflowHandlerandPersistentHandlernow trackidle_sincetimestampidle_sinceis cleared when workflow resumes (receivesStepStateChanged(RUNNING))Definition of "Idle"
A workflow is idle when:
Future Work
This enables future implementation of: