Added a new function in __init__.py : draw_most_recent_execution_mermaid. #265
Conversation
Co-authored-by: cecli (gemini/gemini-2.5-pro)
Draw Mermaid: More refactor Draw Mermaid: More Refactor to clean up Draw Mermaid: More refactor. Draw Mermaid: Nicely Refactored
test: Add tests for draw_most_recent_execution Co-authored-by: cecli (gemini/gemini-2.5-pro) Draw Mermaid: Added in the test case for draw_recent_execution_mermaid
🦋 Changeset detectedLatest commit: 1d15e72 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
a new internal function: Was created to consolidate the graph building logic. Thus BOTH: draw_most_recent_execution uses the same graph building function. |
hippopond
force-pushed
the
draw_mermaid_trace
branch
from
170312a to
10dc6a7
Compare
Pull Request Test Coverage Report for Build 20797409063Details
💛 - Coveralls |
adrianlyjak
left a comment
adrianlyjak
left a comment
There was a problem hiding this comment.
Thanks for the addition! one small comment, and also needs the lints fixed. You can run uv run pre-commit run -a to fix/run them locally.
| "physics": {"enabled": False} | ||
| } | ||
| try: | ||
| import json |
There was a problem hiding this comment.
small thing: keep imports at the top unless there's a good reason. (import slow or conditional dependency). Mind moving up top?
There was a problem hiding this comment.
cool, thanks ! Let me make the adjustments, and turn around !
There was a problem hiding this comment.
Thanks, for the tip on: uv run pre-commit run -a
I was looking for a Makefile that had that, but I know :)
hippopond
force-pushed
the
draw_mermaid_trace
branch
from
fe366cd to
6eecca4
Compare
|
I have just made the adjustment (moved "import json") to the top and now "uv run pre-commit run -a" passes all checks locally. Looking forward the new lint results ! |
|
i see 7 failing checks, let me iterate |
No worries, I got it, merged |
|
Thank you ! |
3 participants
Previously, there were utility functions like:
draw_all_possible_flows
draw_agent_workflow
With the analogous Mermaid functions:
draw_all_possible_flows_mermaid
draw_agent_workflow_mermaid
EXCEPT:
draw_most_recent_execution
Previously Missing:
draw_most_recent_execution_mermaid
This PR creates: draw_most_recent_execution_mermaid
with the corresponding new test case in test_drawing.py::test_draw_most_recent_execution_mermaid