Knowledge entry explaining how to run django tests in Github Actions #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JdFSilva
previously approved these changes
Mar 9, 2023
… all tests have successfully ran
Contributor
Author
|
I added a github action to run the tests and only deploy if those tests run successfully. Also, the test job always runs on each push, but the deploy job only runs if it's the master branch that received the push. There's a small issue though: the test job took almost 18 minutes to run and most of its time was spent in the install poetry dependencies step. Is there any reason for this to take so long? I also noticed that when I installed the dependencies locally, it also took a very long time to complete. @JdFSilva @kenvontucky |
JdFSilva
previously approved these changes
Mar 17, 2023
goncaloadolfo
previously approved these changes
Apr 12, 2023
ctmartinez1992
dismissed stale reviews from goncaloadolfo and JdFSilva
via
90351f3
ghost
previously approved these changes
Apr 26, 2023
goncaloadolfo
previously approved these changes
Apr 27, 2023
ctmartinez1992
dismissed stale reviews from goncaloadolfo and ghost
via
e52258a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't sure where to place this information. I placed it in the testing section, but it seems like it could make sense in the stack and tools section as well.
I made a new page just for this. Right now it only explains how to run Django tests in Github Actions. It makes a lot of assumptions like using poetry and Postgres, but I think that's ok because people can easily infer what may be necessary just by having an example.
I made no mention to the caching possibilities of Github Actions as it can create confusion.