Skip to content

Conversation

@BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented Dec 3, 2025

Draft release notes - rust-lang/rust#149161

@rustbot ping relnotes-interest-group

Rendered

@rustbot
Copy link
Collaborator

rustbot commented Dec 3, 2025

Hi relnotes-interest-group, this PR adds a release blog post. Could you review
the blog post if you have time? Thanks <3

cc @alex-semenyuk @jieyouxu @joshtriplett @Kobzol @lcnr @traviscross

BoxyUwU and others added 2 commits December 10, 2025 17:01
Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com>
Copy link
Contributor

@kpreid kpreid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These suggestions are all copyediting, with no changes in meaning.

BoxyUwU and others added 3 commits December 10, 2025 18:13
Co-authored-by: Kevin Reid <kpreid@switchb.org>
Co-authored-by: Kevin Reid <kpreid@switchb.org>
Co-authored-by: Kevin Reid <kpreid@switchb.org>

Rust's `unused_must_use` lint warns when ignoring the return value of a function, if the function or its return type is annotated with `#[must_use]`. For instance, this warns if ignoring a return type of `Result`, to remind you to use `?`, or something like `.expect("...")`.

However, some functions return `Result`, but the error type they use is not actually "inhabited", meaning it can never exist in real code (e.g. the [`!`](https://doc.rust-lang.org/std/primitive.never.html) or [`Infallible`](https://doc.rust-lang.org/std/convert/enum.Infallible.html) types).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrasing “[the error type] can never exist in real code” is technically incorrect (values of that type can't exist) and generally confusing (what is real code? well, it's likely referring to well-formed code but is that even something worth mentioning?)

Suggested change
However, some functions return `Result`, but the error type they use is not actually "inhabited", meaning it can never exist in real code (e.g. the [`!`](https://doc.rust-lang.org/std/primitive.never.html) or [`Infallible`](https://doc.rust-lang.org/std/convert/enum.Infallible.html) types).
However, some functions return `Result`, but the error type they use is not actually "inhabited", meaning values of that type don't exist (e.g. the [`!`](https://doc.rust-lang.org/std/primitive.never.html) or [`Infallible`](https://doc.rust-lang.org/std/convert/enum.Infallible.html) types).

or […] no values of that type exist or

Suggested change
However, some functions return `Result`, but the error type they use is not actually "inhabited", meaning it can never exist in real code (e.g. the [`!`](https://doc.rust-lang.org/std/primitive.never.html) or [`Infallible`](https://doc.rust-lang.org/std/convert/enum.Infallible.html) types).
However, some functions return `Result`, but the error type they use is not actually "inhabited", meaning you cannot construct any values of that type (e.g. the [`!`](https://doc.rust-lang.org/std/primitive.never.html) or [`Infallible`](https://doc.rust-lang.org/std/convert/enum.Infallible.html) types).

or sth. like that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants