Skip to content

Conversation

@joshka
Copy link

@joshka joshka commented Nov 29, 2025

Often this problem comes up when a github org is set to disallow third party access to the org.
This change is a messaging only change with a direct link to navigate to the offending problem rather than having to read and interpret the docs and then translate that into a github change.

@Turbo87
Copy link
Member

Turbo87 commented Nov 29, 2025

is that the only case in which this can happen?

@joshka
Copy link
Author

joshka commented Nov 29, 2025

is that the only case in which this can happen?

The current .map_err(|_| {...})swallows the real error so currently there's no indication about why the failure happens that's exposed to the user. This makes it a tiny bit better, by giving a reasonable solution to one possible failure but it's not a solution to the error being swallowed.

I may be overindexing on the couple of times I've seen this error message (and had to look up how to fix it).

Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-lang/crates-io any thoughts on this?

IMHO it might be better to add that information to https://doc.rust-lang.org/cargo/reference/publishing.html#github-permissions, since we already link to that. It seems better suited to me to have it there since it allows us to have a longer explanation text there.

@Turbo87 Turbo87 added the C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works label Dec 1, 2025
@LawnGnome
Copy link
Contributor

I wonder if we should be recording these errors somewhere so we can figure out if this is in fact the most common case. (It seems plausible to me, and if it is then I think we should both update the docs and tweak the message, but we don't really have the data to prove that right now.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-backend ⚙️ C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants