Backport #171680 #193
Merged
Backport #171680 #193
+24
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Could you use |
Previously, LLD would always set the implicit entry point for DLLs to the symbol that is prefixed with an underscore. However, mingw-w64 defines it without that underscore. This change fixes that by adding a special branch for MinGW. Also, it simplifies tests that use MinGW style DLL entry symbol by skipping the entry point argument. Note, tests that use MSVC style DLL entry symbol and LLD in MinGW mode, will now require using explicit entry point. I believe this is sensible. When an explicit entry point is passed, i.e. LLD is called by Clang or GCC, there will be no observable difference. Fixes llvm#171441 (cherry picked from commit 2824225)
mati865
force-pushed
the
lld-mingw-backport
branch
from
9cb2e8f to
00d23d1
Compare
Member
Author
|
Sorry, should've followed the docs. Used |
nikic
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of llvm#171680 to address rust-lang/rust#149813.
I didn't ask upstream for backporting because LLVM 21.1.8 was just made and based on the previous tags and https://llvm.org/docs/HowToReleaseLLVM.html, it's likely going to be the final patch release for version 21.
I think the change should be safe, it impacts only MinGW mode of LLD's COFF backend when LLD is not called by Clang or GCC.
The only breakage I could expect is when somebody uses LLD in MinGW mode (by calling
ld.lldwith Windows emulation orlld-linkwith internal-lldmingw") and MSVC libraries instead of mingw-w64. I don't know if such a setup is even possible, but IMO that would be acceptable breakage due to reliance on a bug that this change fixes.