Skip to content

perf: Non-Salsa-interned solver types - with GC for them #21295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ChayimFriedman2 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

perf: Non-Salsa-interned solver types - with GC for them #21295

ChayimFriedman2 wants to merge 2 commits into from

Conversation

@ChayimFriedman2
Copy link
Contributor

@ChayimFriedman2 ChayimFriedman2 commented Dec 17, 2025

This saves an enormous amount of time and memory, as described in #t-compiler/rust-analyzer > Non-copy types for the solver.

@ChayimFriedman2
Lay the basics for non-Copy solver types with GC
ed0081c 
That means stop using Salsa for interning solver types.
@ChayimFriedman2
GC support for solver types
8f294a1 
A GC is triggered every X revisions, and is synchronous, unfortunately.
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ChayimFriedman2 @rustbot