Fix LSP configuration request handling #21297
Open
+16
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
michaelgruenewald
force-pushed
the
fix-lsp-configuration-request
branch
from
43ffcf9 to
e1c9eac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #20837 the extension config API was added. That change sends a configuration to the LSP, that may have been extended by other VS Code extensions. However, there are multiple code path for the rust-analyzer LSP to fetch the configuration: via the initialConfig that was changed in the original PR, and via an LSP request that was missed in the original PR. This fixes that by using the same config structure instead of letting the generic vscode-languageclient code handle it. There is only one user of that specific LSP request in rust-analyzer here, so we don't need the extra overhead of supporting other configuration sections.