-
Notifications
You must be signed in to change notification settings - Fork 219
Don't create msi links for windows gnullvm targets #975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@arnabanimesh just to understand the context of this patch. The fact that the A bit more context in the description would be helpful for those (like me) in the project not extremely familiar about our releases artifacts. Thanks. |
|
@apiraino Added proper explanation in the description |
|
I was curious so I asked: https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/No.20Windows.20.2Emsi.20packages.20for.20targets.20.60-gnullvm.60/near/553825621 Please let's wait a sec before merging this. @rustbot label S-blocked |
|
We have got an answer for why we don't yet produce Until that's done (cc rust-lang/rust#148751), I think we can move along, and when the situation changes we can revert this PR. @rustbot label -S-blocked |
Urgau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for bringing this up.
Since msi installers for windows gnullvm targets are not being published, it should not be part of the documentation.
Ideally it would be better if there would be msi installers for these targets in my opinion though.