[DO NOT MERGE] -Znext-solver=globally experiments
#133502
Draft
+92
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
rust4
branch
from
c3ef9cd to
f631ca8
Compare
Member
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 27, 2024
[DO NOT MERGE] bootstrap with `-Znext-solver=globally` A revival of rust-lang#124812. Current status, we're failing in: - failing in `rustc_next_trait_solver` with 126 instances of the following error ``` error[E0311]: the parameter type `I` may not live long enough | help: consider adding an explicit lifetime bound --> compiler/rustc_next_trait_solver/src/solve/trait_goals.rs:624:53 | 624 ~ fn consider_structural_builtin_unsize_candidates<'a>( 625 ~ ecx: &mut EvalCtxt<'a, D>, 626 | goal: Goal<I, Self>, 627 ~ ) -> Vec<Candidate<I>> where I: 'a { ``` - `itertools` hangs, we're already encountered this hang in our previous attempt due to large type sizes. I believe that it's simply caused by a missing cache somewhere, potentially in `wf.rs`, but other visitors may also be responsible. See rust-itertools/itertools#945 for more details ### commits - rust-lang#133501 - rust-lang#133493 - 9456bfe and b21b116 reimplement candidate preference based on rust-lang#132325, not yet a separate PR - c3ef9cd is a rebased version of rust-lang#125334, unsure whether I actually want to land this PR for now r? `@ghost`
Collaborator
Member
|
I also pushed:
I think this is sufficient to make the compiler build, or at least |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment has been minimized.
This comment has been minimized.
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-author
Collaborator
|
☔ The latest upstream changes (presumably #133527) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
Next failure is on
pub fn repro() -> impl FnMut() {
if true {
|| ()
} else {
|| ()
}
} |
compiler-errors
force-pushed
the
rust4
branch
from
f631ca8 to
6210ed3
Compare
Member
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 27, 2024
[DO NOT MERGE] bootstrap with `-Znext-solver=globally` A revival of rust-lang#124812. Current status: `./x.py b --stage 2` passes 🎉 ### commits - rust-lang#133501 - rust-lang#133493 - 9456bfe and b21b116 reimplement candidate preference based on rust-lang#132325, not yet a separate PR - c3ef9cd is a rebased version of rust-lang#125334, unsure whether I actually want to land this PR for now - rust-lang#133517 * rust-lang#133518 * rust-lang#133519 * rust-lang#133520 * rust-lang#133521 * rust-lang#133524 r? `@ghost`
Collaborator
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
|
💔 Test failed - checks-actions |
compiler-errors
force-pushed
the
rust4
branch
from
6210ed3 to
8fa8f40
Compare
Member
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 27, 2024
[DO NOT MERGE] bootstrap with `-Znext-solver=globally` A revival of rust-lang#124812. Current status: `./x.py b --stage 2` passes 🎉 ### commits - rust-lang#133501 - rust-lang#133493 - 9456bfe and b21b116 reimplement candidate preference based on rust-lang#132325, not yet a separate PR - c3ef9cd is a rebased version of rust-lang#125334, unsure whether I actually want to land this PR for now - rust-lang#133517 * rust-lang#133518 * rust-lang#133519 * rust-lang#133520 * rust-lang#133521 * rust-lang#133524 r? `@ghost`
Collaborator
Member
|
I was reducing the new failure but you've already fixed it ^^ |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
lcnr
changed the title
-Znext-solver=globally -Znext-solver=globally experiments
Contributor
Author
|
@bors try |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Dec 16, 2025
[DO NOT MERGE] `-Znext-solver=globally` experiments
Contributor
Author
|
@bors try |
rust-bors bot
added a commit
that referenced
this pull request
Dec 16, 2025
[DO NOT MERGE] `-Znext-solver=globally` experiments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
💔 Test for 065bb3d failed: CI. Failed jobs:
|
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@bors try |
rust-bors bot
added a commit
that referenced
this pull request
Dec 16, 2025
[DO NOT MERGE] `-Znext-solver=globally` experiments
This comment has been minimized.
This comment has been minimized.
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot)For more information how to resolve CI failures of this job, visit this link. |
Member
|
@craterbot run mode=check-only name=2025-12-16-next-solver-global |
Collaborator
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
craterbot
added
S-waiting-on-crater
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A revival of #124812. See
-Znext-solver#107374Current status:
./x.py b --stage 2passes 🎉trybuilds succeed 🎉 🎉 🎉first perf run 👻 second perf run 👻 third perf run 👻
crater
This does not detect hangs or memory issues.
in-flight changes
-Znext-solverRemove the forced ambiguity hack from search graph #149904r? @ghost
Footnotes
a complete crater run ↩ ↩2
with doubled
recursion_limitwhen evaluating goals ↩ ↩2 ↩3 ↩4 ↩5 ↩6only testing crates which may have regressed from the above run ↩ ↩2 ↩3 ↩4 ↩5 ↩6