-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
Move std::io::pipe code into its own file
#135635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is a duplicate of #135583. As the other one is approved already, I'm closing this one. Feel free to reopen if the other PR does not address everything done here. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This PR modifies cc @jieyouxu |
This comment has been minimized.
This comment has been minimized.
std::pipe::{pipe, PipeReader, PipeWriter} to std::iostd::io::pipe code into its own file
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@tbu- could you rebase? |
I'll open a stabilization PR. |
|
The merge is conflict-free but GH does not automatically drop commits, so the diff view is incorrect. |
This comment was marked as outdated.
This comment was marked as outdated.
|
Great, thank you! |
|
@bors r- ('fixing' desync) |
|
isn;t this PR akready merged? |
|
Yes but the bors queue is slightly out of sync atm and this merged PR showed up in the "merge queue", I had to kick it out. We have a proper procedure for resyncing the queue but that takes ~45 minutes and I didn't want to do that rn (for several reasons). |
Also update the docs for the new location, create a section "Platform-specific behavior", don't hide required imports for code examples.