Skip to content

Conversation

@tbu-
Copy link
Contributor

@tbu- tbu- commented Jan 17, 2025

Also update the docs for the new location, create a section "Platform-specific behavior", don't hide required imports for code examples.

@rustbot
Copy link
Collaborator

rustbot commented Jan 17, 2025

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 17, 2025
@joboet
Copy link
Member

joboet commented Jan 17, 2025

This is a duplicate of #135583.

As the other one is approved already, I'm closing this one. Feel free to reopen if the other PR does not address everything done here.

@joboet joboet closed this Jan 17, 2025
@rust-log-analyzer

This comment has been minimized.

@tbu-
Copy link
Contributor Author

tbu- commented Jan 17, 2025

@joboet I can't re-open since a maintainer closed it. Could you reopen this PR? I'll base it on top off #135583.

@ChrisDenton ChrisDenton reopened this Jan 17, 2025
@rust-log-analyzer

This comment has been minimized.

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs O-unix Operating system: Unix-like labels Jan 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 17, 2025

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

@rust-log-analyzer

This comment has been minimized.

@tbu- tbu- changed the title Move std::pipe::{pipe, PipeReader, PipeWriter} to std::io Move std::io::pipe code into its own file Jan 17, 2025
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@NobodyXu
Copy link
Contributor

#135583 has been merged

cc @tbu- sorry that I didn't see your PR for this, I was planning on also opening a PR for stabilisation, but maybe you can do it within this PR?

@tgross35
Copy link
Contributor

@tbu- could you rebase?

@tbu-
Copy link
Contributor Author

tbu- commented Jan 21, 2025

@tgross35 There appear to be no merge conflicts according to my local git. I included the same commits as #135583, so git should handle it just fine.

@tbu-
Copy link
Contributor Author

tbu- commented Jan 21, 2025

I was planning on also opening a PR for stabilisation, but maybe you can do it within this PR?

I'll open a stabilization PR.

@tgross35
Copy link
Contributor

The merge is conflict-free but GH does not automatically drop commits, so the diff view is incorrect.

@tbu-

This comment was marked as outdated.

@joboet
Copy link
Member

joboet commented Jan 24, 2025

Great, thank you!
@bors r+

@fmease
Copy link
Member

fmease commented Feb 2, 2025

@bors r- ('fixing' desync)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 2, 2025
@NobodyXu
Copy link
Contributor

NobodyXu commented Feb 2, 2025

isn;t this PR akready merged?

@fmease
Copy link
Member

fmease commented Feb 2, 2025

Yes but the bors queue is slightly out of sync atm and this merged PR showed up in the "merge queue", I had to kick it out. We have a proper procedure for resyncing the queue but that takes ~45 minutes and I didn't want to do that rn (for several reasons).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-run-make Area: port run-make Makefiles to rmake.rs O-unix Operating system: Unix-like S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants