-
Notifications
You must be signed in to change notification settings - Fork 335
feat: set GitHub actions integration ID for ruleset CI checks #2200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Dry-run check results |
|
Thanks! |
| writeln!(result, " Checks:")?; | ||
| for check in ¶meters.required_status_checks { | ||
| if let Some(integration_id) = check.integration_id { | ||
| let app_name = if integration_id == GITHUB_ACTIONS_INTEGRATION_ID { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it should show something like below
Rule: Required Status Checks
Strict Policy: false
Checks:
- CI (GitHub Actions, integration_id: 15368)
- test (GitHub Actions, integration_id: 15368)| } | ||
|
|
||
| if !is_create && !logged { | ||
| writeln!(result, " No changes")?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a change here. I do remember I need to convert the macro into a general function. I will take it up in a separate PR. In this PR, I'm adding a check for a clear description. If there are no changes, it must print.
Ruleset for main
No changesinstead of just printing
Ruleset for main
5a89739 to
ff7c6b1
Compare
Closes #2197
Summary
This PR configures repository rulesets only to accept CI status checks from GitHub Actions by setting the
integration_idto15368.Changes
GITHUB_ACTIONS_INTEGRATION_IDconstant (value:15368) with verification linkconstruct_ruleset()to use the GitHub Actions integration ID for required status checksVerification
The integration ID was verified via the public GitHub API: