Add VTT vertical position support when converting from ttml #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, team! Thanks for this awesome tool for helping us convert the subtitle format. My team is mainly working on the APAC related subtitles and we found there are some issues while converting the ttml file to VTT. One of the problem is that the output VTT file didn't include the vertical information even though the original ttml writingMode was defined the vertical subtitle in layout field. I added some configuration in VTT writer side so that when converting from ttml file, the vertical subtitle could be reserved. Thanks for reviewing and please let me know if there is any other cases we need to consider. Example screenshot below.
